Skip to content

Conversation

@lengrongfu
Copy link
Contributor

@lengrongfu lengrongfu commented Aug 25, 2025

Purpose

#23468

Test Plan

  • config.yaml
served-model-name:
 - qwen3
 - qwen1.7B

running command: vllm serve Qwen/Qwen3-1.7B --trust-remote-code --gpu-memory-utilization 0.95 --enforce-eager --config ./config.yaml

{"object":"list","data":[{"id":"qwen3 qwen1.7B","object":"model","created":1756104016,"owned_by":"vllm","root":"Qwen/Qwen3-1.7B","parent":null,"max_model_len":40960,"permission":[{"id":"modelperm-fa4a2d5e1703478293a0cf1cbcbcb5f7","object":"model_permission","created":1756104016,"allow_create_engine":false,"allow_sampling":true,"allow_logprobs":true,"allow_search_indices":false,"allow_view":true,"allow_fine_tuning":false,"organization":"*","group":null,"is_blocking":false}]}]}

Test Result

  • use qwen1.7B model name to send api
curl -X POST "http://localhost:8000/v1/chat/completions"     -H "Content-Type: application/json"      --data '{
                "model": "qwen1.7B",
                "messages": [
                        {
                                "role": "user",
                                "content": "What is the capital of France?"
                        }
                ]
        }'
  • use qwen3 model name to send api
curl -X POST "http://localhost:8000/v1/chat/completions"     -H "Content-Type: application/json"      --data '{
                "model": "qwen3",
                "messages": [
                        {
                                "role": "user",
                                "content": "What is the capital of France?"
                        }
                ]
        }'

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds support for list values in YAML configuration files, which is a valuable improvement for arguments that accept multiple values. The implementation is clean and directly addresses the reported issue. I've identified one edge case concerning empty lists that could lead to a runtime error, and I've provided a suggestion to handle it.

@lengrongfu
Copy link
Contributor Author

@DarkLight1337 hello, please take a look, thanks ~

@lengrongfu lengrongfu force-pushed the fix/yaml-served-model-name branch 2 times, most recently from 80e456c to 28a5154 Compare August 26, 2025 06:02
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
@lengrongfu lengrongfu force-pushed the fix/yaml-served-model-name branch from 28a5154 to c534e5b Compare August 26, 2025 08:54
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix pre-commit

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 27, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 27, 2025 04:06
@DarkLight1337 DarkLight1337 merged commit 8dbf6ed into vllm-project:main Aug 27, 2025
45 checks passed
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…project#23528)

Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants