-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
[Bugfix] fix when config.yaml config value is list parse error #23528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] fix when config.yaml config value is list parse error #23528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds support for list values in YAML configuration files, which is a valuable improvement for arguments that accept multiple values. The implementation is clean and directly addresses the reported issue. I've identified one edge case concerning empty lists that could lead to a runtime error, and I've provided a suggestion to handle it.
|
@DarkLight1337 hello, please take a look, thanks ~ |
80e456c to
28a5154
Compare
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
28a5154 to
c534e5b
Compare
DarkLight1337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix pre-commit
…project#23528) Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
…project#23528) Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…project#23528) Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
…project#23528) Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
…project#23528) Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Purpose
#23468
Test Plan
running command:
vllm serve Qwen/Qwen3-1.7B --trust-remote-code --gpu-memory-utilization 0.95 --enforce-eager --config ./config.yamlTest Result
qwen1.7Bmodel name to send apiqwen3model name to send api(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.