Add glm4.5v tp2,4 fp8 config on H100_80GB #23443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenxi-yang
requested review from
mgoin,
robertgshaw2-redhat,
tlrmchlsmth and
yewentao256
as code owners
|
This pull request was exported from Phabricator. Differential Revision: D80713433 |
chenxi-yang
force-pushed
the
export-D80713433
branch
from
54eb4a9 to
03e06d5
Compare
Summary: Pull Request resolved: vllm-project#23443 as title, generated with D80713197 Test Plan: Run fused_moe on H100_80GB Rollback Plan: Reviewed By: zzh142857 Differential Revision: D80713433
|
This pull request was exported from Phabricator. Differential Revision: D80713433 |
chenxi-yang
force-pushed
the
export-D80713433
branch
from
03e06d5 to
ab94208
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds new FP8 configurations for glm4.5v on H100_80GB GPUs with tensor parallelism of 2 and 4. It introduces a new environment variable VLLM_USE_FUSED_MOE_KERNEL_IN_COMPRESSED_QUANTIZATION to control the fused MoE kernel usage. The tensor parallelism logic in glm4_1v.py is refactored to align with vLLM's standard implementation. My review includes a suggestion to refactor duplicated code in compressed_tensors_moe.py to improve maintainability.
DarkLight1337
approved these changes
Aug 23, 2025
github-actions
bot
added
the
ready
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Chenxi Yang <cxyang@meta.com>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Chenxi Yang <cxyang@meta.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
Co-authored-by: Chenxi Yang <cxyang@meta.com>
mengxingkongzhouhan
pushed a commit
to mengxingkongzhouhan/vllm
that referenced
this pull request
Aug 30, 2025
Co-authored-by: Chenxi Yang <cxyang@meta.com>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
Co-authored-by: Chenxi Yang <cxyang@meta.com>
ekagra-ranjan
pushed a commit
to ekagra-ranjan/vllm
that referenced
this pull request
Sep 4, 2025
Co-authored-by: Chenxi Yang <cxyang@meta.com> Signed-off-by: Ekagra Ranjan <3116519+ekagra-ranjan@users.noreply.github.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Co-authored-by: Chenxi Yang <cxyang@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: as title, generated with D80713197
Test Plan:
Run fused_moe on H100_80GB
Rollback Plan:
Reviewed By: zzh142857
Differential Revision: D80713433