[CI/Build] Skip Idefics3 and SmolVLM generation test again #23356
Conversation
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to temporarily disable generation tests for Idefics3 and SmolVLM by bumping the minimum required transformers version, due to an issue in recent releases.
The change for Idefics3ForConditionalGeneration correctly sets min_transformers_version to 4.56, which will skip the tests on older versions. However, for SmolVLMForConditionalGeneration, max_transformers_version is used instead of min_transformers_version. This appears to be a mistake, as it will not prevent the tests from running on the problematic 4.55.x versions. I've added a comment with a suggested fix to align the behavior for both models.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…ect#23356) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: root <xwq391974@alibaba-inc.com>
…ect#23356) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ect#23356) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…ect#23356) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ect#23356) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ect#23356) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…ect#23356) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
3 participants
Purpose
(This really drives me crazy 🤪)
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.