[Fix] remove is_marlin param in benchmark_moe #23286
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Shixian Cui <shixian@amazon.com>
|
@mgoin could you take a look at this 1 line fix? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes an extraneous is_marlin parameter from the get_default_config function call in benchmark_moe.py. This change is necessary as the parameter does not exist in the function's signature, and its presence would lead to a TypeError at runtime. The fix is straightforward and resolves the issue.
|
Thanks for finding, I left this behind |
github-actions
bot
added
the
ready
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
2 participants
Purpose
1 line fix to remove extra
is_marlinparam in benchmark_moe.py after PR #23006Test Plan
python3 benchmark_moe.py
Test Result
python3 benchmark_moe.py passed
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.