Skip to content

Small fix for Command-A-Vision #23268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DarkLight1337 merged 1 commit into from
Aug 20, 2025
Merged

Small fix for Command-A-Vision #23268

DarkLight1337 merged 1 commit into from
Aug 20, 2025

Conversation

@dongluw
Copy link
Contributor

@dongluw dongluw commented Aug 20, 2025 •
edited by github-actions bot
Loading

Purpose

Read text model architecture from config

Test Plan

Test Result

python3 examples/offline_inference/vision_lan
guage_multi_image.py --model-type command_a_vision

--------------------------------------------------
The first image shows a mallard duck swimming in blue water, while the second image depicts a lion sitting in a field of tall, dry grass.
--------------------------------------------------

(Optional) Documentation Update

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@dongluw
read text model arch from config
eca85d9 
Signed-off-by: donglu <donglu@cohere.com>
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the initialization of the Cohere2VisionForConditionalGeneration model to be more robust. Instead of hardcoding the language model architecture as ["Cohere2ForCausalLM"], the change now dynamically reads the architecture from the config.text_config.architectures attribute. This is a good improvement, making the model more flexible and correctly relying on the provided configuration. The change is correct and I have no further suggestions.

@github-actions
Copy link

github-actions bot commented Aug 20, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 20, 2025 15:39
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 20, 2025
@DarkLight1337 DarkLight1337 merged commit ebe56a0 into vllm-project:main Aug 20, 2025
45 of 47 checks passed
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
@dongluw @djmmoss
Small fix for Command-A-Vision (vllm-project#23268)
582c727 
Signed-off-by: donglu <donglu@cohere.com>
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
shanes-cerebras pushed a commit to smsegal/vllm that referenced this pull request Aug 24, 2025
@dongluw @shanes-cerebras
Small fix for Command-A-Vision (vllm-project#23268)
3ade130 
Signed-off-by: donglu <donglu@cohere.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
@dongluw @epwalsh
Small fix for Command-A-Vision (vllm-project#23268)
f9c61ee 
Signed-off-by: donglu <donglu@cohere.com>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
@dongluw @amd-xiaoyu12
Small fix for Command-A-Vision (vllm-project#23268)
d81625b 
Signed-off-by: donglu <donglu@cohere.com>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
@dongluw @zhewenl
Small fix for Command-A-Vision (vllm-project#23268)
02ebb71 
Signed-off-by: donglu <donglu@cohere.com>
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
@dongluw @mengxingkongzhouhan
Small fix for Command-A-Vision (vllm-project#23268)
a0f87d5 
Signed-off-by: donglu <donglu@cohere.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
@dongluw @zhewenl
Small fix for Command-A-Vision (vllm-project#23268)
da9c3a7 
Signed-off-by: donglu <donglu@cohere.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@dongluw @FeiDaLI
Small fix for Command-A-Vision (vllm-project#23268)
dc0c410 
Signed-off-by: donglu <donglu@cohere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dongluw @DarkLight1337