Skip to content

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Aug 18, 2025

Purpose

  • We skipped several tests due to regression on Transformers v4.55.0. (Fuyu, idefics3 and gpt_bigcode etc)
  • Update transformers to patch release v4.55.2 to get them fixed.

Test Plan

Test Result

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify mergify bot added the ci/build label Aug 18, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the transformers library from version 4.55.0 to 4.55.2. The change is motivated by the need to fix regressions present in the previous version. The version is correctly updated in requirements/common.txt to set the new minimum, and pinned in requirements/test.in and the corresponding lock file requirements/test.txt for reproducible testing. The changes are straightforward and look correct. I have no further comments.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 19, 2025
@DarkLight1337
Copy link
Member

PTAL at failing distributed tests

@Isotr0py
Copy link
Member Author

Ah, both v4.55.1 and v4.55.2 patch release missed the mllama regression fix. 😓

Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify mergify bot added llama Related to Llama models multi-modality Related to multi-modality (#4194) labels Aug 19, 2025
@Isotr0py Isotr0py enabled auto-merge (squash) August 19, 2025 14:13
@vllm-bot vllm-bot merged commit d6a1a20 into vllm-project:main Aug 19, 2025
69 of 71 checks passed
princepride pushed a commit to princepride/vllm that referenced this pull request Aug 20, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py Isotr0py deleted the update-transformers branch August 20, 2025 04:28
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
cyang49 pushed a commit to cyang49/vllm that referenced this pull request Aug 20, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Duncan Moss <djm.moss@gmail.com>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Xiao Yu <xiao.yu@amd.com>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
prashantgupta24 added a commit to prashantgupta24/aiu-fms-testing-utils that referenced this pull request Sep 15, 2025
This is required for vllm 0.10.2, see vllm-project/vllm#23093

Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build llama Related to Llama models multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants