[Misc] enhance static type hint #23059
Conversation
andyxning
requested review from
WoosukKwon,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat and
ywang96
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly enhances the static type hint for the device parameter in load_lora_model from str to torch.device. I've suggested a minor formatting improvement for the function signature to better align with standard Python style guides.
There was a problem hiding this comment.
The parentheses around the return type annotation are unnecessary and unconventional. While syntactically valid, this formatting deviates from PEP 8, which can harm readability and maintainability. A better way to handle a long function signature is to use a backslash for line continuation.
| lora_config: LoRAConfig, device: torch.device) -> ( | |
| nn.Module): | |
| lora_config: LoRAConfig, device: torch.device) -> \ | |
| nn.Module: |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Andy Xie <andy.xning@gmail.com>
andyxning
force-pushed
the
enhance_static_type_hint
branch
from
4e9850f to
58bd8dc
Compare
|
LGTM thanks |
github-actions
bot
added
the
ready
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Duncan Moss <djm.moss@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
Signed-off-by: Andy Xie <andy.xning@gmail.com>
4 participants
Purpose
Enhance code static type hint.
Test Plan
NA
Test Result
NA
(Optional) Documentation Update
NA
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.