[CI] [Doc]: Add GH Action for auto labeling issues with rocm tag
#20988
Conversation
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
| if (escapedExclusions.length > 0) { | ||
| const exclusionPattern = escapedExclusions.join('|'); | ||
| return new RegExp(`\\b(?!.*(?:${exclusionPattern}))(${keywordPattern})\\b`, 'i'); | ||
| } | ||
|
|
||
| return new RegExp(`\\b(${keywordPattern})\\b`, 'i'); |
There was a problem hiding this comment.
| if (escapedExclusions.length > 0) { | |
| const exclusionPattern = escapedExclusions.join('|'); | |
| return new RegExp(`\\b(?!.*(?:${exclusionPattern}))(${keywordPattern})\\b`, 'i'); | |
| } | |
| return new RegExp(`\\b(${keywordPattern})\\b`, 'i'); | |
| if (escapedExclusions.length === 0) { | |
| return new RegExp(`\\b(${keywordPattern})\\b`, 'i'); | |
| } | |
| const exclusionPattern = escapedExclusions.join('|'); | |
| return new RegExp(`\\b(?!.*(?:${exclusionPattern}))(${keywordPattern})\\b`, 'i'); |
There was a problem hiding this comment.
Handle the simple case first
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
[CI] [ROCm] update rocm issue auto label
| "amd radeon rx 9070", | ||
| "amd radeon rx 9070 xt", | ||
| "amd radeon rx 9070 gre", | ||
| "amd radeon ai pro r9700", | ||
| "amd radeon rx 9060 xt", | ||
| "amd radeon rx 7900 xtx", | ||
| "amd radeon rx 7900 xt", | ||
| "amd radeon rx 7900 gre", | ||
| "amd radeon rx 7800 xt", | ||
|
|
||
| // GPU Models - Pro Series | ||
| "amd radeon pro w7900", | ||
| "amd radeon pro w7900 dual slot", | ||
| "amd radeon pro w7800", | ||
| "amd radeon pro w7800 48gb", | ||
| "amd radeon pro w7700", | ||
| "amd radeon pro v710", | ||
| "amd radeon pro v620", | ||
| "amd radeon pro w6800", |
There was a problem hiding this comment.
can you simplify these instances? (1) use "radeon" only, as "amd" is already listed. (2) Also, is there a need to list all of these instances, since you are using regression expression?
There was a problem hiding this comment.
These has been simplify. Given that the product name like w7900 w7800 etc are mainly unique to AMD GPU product, so the product name are still retained.
| "amd instinct mi325x", | ||
| "amd instinct mi300x", | ||
| "amd instinct mi300a", | ||
| "amd instinct mi250x", | ||
| "amd instinct mi250", | ||
| "amd instinct mi210", | ||
| "amd instinct mi350x", | ||
| "amd instinct mi355x", |
There was a problem hiding this comment.
same here, simplify instead of list all the mixxx instances
There was a problem hiding this comment.
Theses are shorten instead of using regex as in the reviewer would like to keep the feature easier to extend by not asking developer to write regex syntax when adding new keywords or sub-string.
| "cdna3", | ||
| "cdna2", | ||
| "cdna4", | ||
| "cdna", | ||
| "gfx942", | ||
| "gfx90a", | ||
| "gfx1100", | ||
| "gfx1101", | ||
| "gfx1201", | ||
| "gfx1200", | ||
| "gfx1030", | ||
| "gfx950", | ||
| "gfx908", | ||
| "rdna4", | ||
| "rdna3", | ||
| "rdna2", |
There was a problem hiding this comment.
same here to simplify
There was a problem hiding this comment.
Done. Added a new matching feature: substring match. So we have simplify these to just do a substring match
cdna gfx and rdna.
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
DarkLight1337
added
the
ready
…llm-project#20988) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Signed-off-by: tc-mb <caitianchi@modelbest.cn>
…llm-project#20988) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
…llm-project#20988) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk> Signed-off-by: Xiao Yu <xiao.yu@amd.com>
…llm-project#20988) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
…llm-project#20988) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
…llm-project#20988) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Co-authored-by: Cyrus Leung <tlleungac@connect.ust.hk>
5 participants
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
As vLLM expands ROCm/AMD support (e.g., for MI300X, MI350X, CDNA4, and Radeon series), issues mentioning these often need quick triage. This workflow automatically adds the "rocm" label (existing in repo) to matching issues, improving community support. It complements the PR labeler (file-path based) by focusing on issues via keywords.
This PR introduces a GitHub Action that automatically labels issues based on configurable keywords, substrings, and regex patterns found in issue titles and bodies. The action helps maintain consistent labeling across the repository and reduces manual triage effort.
Features
Multi-Pattern Matching Support
\bmi\d{3}[a-z]*\bfor AMD GPU names like "mi300x")Flexible Search Locations
Each pattern can be configured to search in:
title: Only in issue titlebody: Only in issue bodyboth: In both title and body (default)Detailed Logging
How It Works
Trigger Events
The action runs on:
issues.opened- New issuesissues.edited- Modified issuesissues.reopened- Reopened issuesConcurrency Control
Uses issue-specific concurrency groups to prevent race conditions when multiple events occur simultaneously on the same issue.
Processing Flow
searchInsetting📝 Configuration Structure
Extending for Your Use Case
Adding New Labels
labelConfig:Example Output
When processing an issue, the action provides detailed logs:
Current Configuration
The action is currently configured to auto-label issues with
rocmbased on ROCm-related terms, AMD GPU references, and HIP-related keywords. This serves as a comprehensive example of all matching types in action.This action provides a robust foundation for automated issue labeling that can be easily extended and customized for any repository's specific needs.
Test Plan
This GH action workflow is now active on https://github.com/vllm-project/vllm/issues , create a github issue and check the github actions output.
Test Result
Created 30 non-ROCm related issue by extracting actual issues from vllm-project/vllm from past 7 days. All didn't trigger ROCm label
Extracted all rocm related issues from past 7 days to test True Positives
(Optional) Documentation Update