Skip to content

[Bugfix] Fix missing int type for -n in multi-image example#17223

Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Isotr0py:fix-vision-example
Apr 26, 2025
Merged

[Bugfix] Fix missing int type for -n in multi-image example#17223
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Isotr0py:fix-vision-example

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Apr 26, 2025 •
edited by github-actions bot
Loading

  • Fix missing type=int for -n in vision_language_multi_image.py:
vision_language_multi_image.py: error: argument --num-images/-n: invalid choice: '3' (choose from 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12)

@github-actions
Copy link

github-actions bot commented Apr 26, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 26, 2025
@Isotr0py Isotr0py requested a review from DarkLight1337 April 26, 2025 07:29
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 26, 2025 07:35
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 26, 2025
@DarkLight1337 DarkLight1337 merged commit 8c1c926 into vllm-project:main Apr 26, 2025
30 of 32 checks passed
@Isotr0py Isotr0py deleted the fix-vision-example branch April 26, 2025 12:47
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@Isotr0py
[Bugfix] Fix missing int type for -n in multi-image example (vllm-p…
d2aa266 
…roject#17223)
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@Isotr0py @lk-chen
[Bugfix] Fix missing int type for -n in multi-image example (vllm-p…
5560900 
…roject#17223)
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@Isotr0py @adobrzyn
[Bugfix] Fix missing int type for -n in multi-image example (vllm-p…
695afc3 
…roject#17223)

Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Isotr0py
[Bugfix] Fix missing int type for -n in multi-image example (vllm-p…
537942d 
…roject#17223)

Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@Isotr0py
[Bugfix] Fix missing int type for -n in multi-image example (vllm-p…
f2e31e5 
…roject#17223)

Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Isotr0py @DarkLight1337