Skip to content

[Bugfix] Fix distributed bug again in Qwen2.5-VL & Qwen2.5-Omni#16974

Merged
DarkLight1337 merged 3 commits intovllm-project:mainfrom
fyabc:qwen2_omni_public_v1
Apr 22, 2025
Merged

[Bugfix] Fix distributed bug again in Qwen2.5-VL & Qwen2.5-Omni#16974
DarkLight1337 merged 3 commits intovllm-project:mainfrom
fyabc:qwen2_omni_public_v1

Conversation

@fyabc
Copy link
Contributor

@fyabc fyabc commented Apr 22, 2025 •
edited by github-actions bot
Loading

I am very sorry that previous fix #16907 still have distributed bug, need to fix it agin.

Related PR: #15130 and #16907

@github-actions
Copy link

github-actions bot commented Apr 22, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@fyabc
Copy link
Contributor Author

fyabc commented Apr 22, 2025

@DarkLight1337 @ywang96 very sorry to bother you, please check it again...

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 22, 2025 10:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 22, 2025
@DarkLight1337 DarkLight1337 merged commit 571e8dd into vllm-project:main Apr 22, 2025
49 of 52 checks passed
frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
@fyabc @frieda-huang
[Bugfix] Fix distributed bug again in Qwen2.5-VL & Qwen2.5-Omni (vllm…
ad8a4b9 
…-project#16974)

Signed-off-by: fyabc <suyang.fy@alibaba-inc.com>
Signed-off-by: Frieda (Jingying) Huang <jingyingfhuang@gmail.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@fyabc
[Bugfix] Fix distributed bug again in Qwen2.5-VL & Qwen2.5-Omni (vllm…
129cb99 
…-project#16974)

Signed-off-by: fyabc <suyang.fy@alibaba-inc.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@fyabc @lk-chen
[Bugfix] Fix distributed bug again in Qwen2.5-VL & Qwen2.5-Omni (vllm…
aa38a54 
…-project#16974)

Signed-off-by: fyabc <suyang.fy@alibaba-inc.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@fyabc @adobrzyn
[Bugfix] Fix distributed bug again in Qwen2.5-VL & Qwen2.5-Omni (vllm…
1198573 
…-project#16974)

Signed-off-by: fyabc <suyang.fy@alibaba-inc.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@fyabc
[Bugfix] Fix distributed bug again in Qwen2.5-VL & Qwen2.5-Omni (vllm…
40a96a9 
…-project#16974)

Signed-off-by: fyabc <suyang.fy@alibaba-inc.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
@DarkLight1337 DarkLight1337 mentioned this pull request Jul 24, 2025
Closed
4 tasks
@gcanlin gcanlin mentioned this pull request Nov 8, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fyabc @DarkLight1337