Skip to content

[Model] Use autoweightloader for mamba#16950

Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom
sfeng33:use-autoweightloader
Apr 22, 2025
Merged

[Model] Use autoweightloader for mamba#16950
DarkLight1337 merged 2 commits intovllm-project:mainfrom
sfeng33:use-autoweightloader

Conversation

@sfeng33
Copy link
Contributor

@sfeng33 sfeng33 commented Apr 22, 2025 •
edited by github-actions bot
Loading

Partially fixes #15697
Verified mamba model loaded with following command

vllm serve mistralai/Mamba-Codestral-7B-v0.1

sfeng33 added 2 commits April 22, 2025 00:29
@sfeng33
[Model] Use AutoWeightsLoader for mamba
c23ee2d
@sfeng33
Format
58c92a9 
Signed-off-by: sfeng33 <4florafeng@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 22, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@sfeng33 sfeng33 marked this pull request as draft April 22, 2025 00:47
@sfeng33 sfeng33 marked this pull request as ready for review April 22, 2025 00:52
DarkLight1337
DarkLight1337 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 22, 2025 05:36
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 22, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Apr 22, 2025 •
edited
Loading

Next time please satisfy the DCO check

@DarkLight1337 DarkLight1337 merged commit 2689d5c into vllm-project:main Apr 22, 2025
64 of 65 checks passed
@sfeng33
Copy link
Contributor Author

sfeng33 commented Apr 22, 2025

Thanks for the review!

frieda-huang pushed a commit to frieda-huang/vllm that referenced this pull request Apr 23, 2025
@sfeng33 @frieda-huang
[Model] Use autoweightloader for mamba (vllm-project#16950)
feb73a1 
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: Frieda (Jingying) Huang <jingyingfhuang@gmail.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@sfeng33
[Model] Use autoweightloader for mamba (vllm-project#16950)
3127780 
Signed-off-by: sfeng33 <4florafeng@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@sfeng33 @lk-chen
[Model] Use autoweightloader for mamba (vllm-project#16950)
f728e02 
Signed-off-by: sfeng33 <4florafeng@gmail.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@sfeng33 @adobrzyn
[Model] Use autoweightloader for mamba (vllm-project#16950)
4a7d3a3 
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@sfeng33
[Model] Use autoweightloader for mamba (vllm-project#16950)
2fe04f2 
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
@sfeng33 sfeng33 deleted the use-autoweightloader branch June 14, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Composite model loading using AutoWeightsLoader for all models

2 participants

@sfeng33 @DarkLight1337