Skip to content

[Docs] Fix a link and grammar issue in production-stack.md#16809

Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom
windsonsea:helmsh
Apr 18, 2025
Merged

[Docs] Fix a link and grammar issue in production-stack.md#16809
DarkLight1337 merged 1 commit intovllm-project:mainfrom
windsonsea:helmsh

Conversation

@windsonsea
Copy link
Contributor

@windsonsea windsonsea commented Apr 18, 2025 •
edited by github-actions bot
Loading

  • fix a 404 link
  • minor change a clause for clear clarity

@windsonsea
[Docs] Fix a link and grammar issue in production-stack.md
76c93c1 
Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
@github-actions
Copy link

github-actions bot commented Apr 18, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 18, 2025
DarkLight1337
DarkLight1337 approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 18, 2025 05:15
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 18, 2025
@DarkLight1337 DarkLight1337 merged commit 26507f8 into vllm-project:main Apr 18, 2025
36 of 38 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@windsonsea @yangw-dev
[Docs] Fix a link and grammar issue in production-stack.md (vllm-proj…
b49775c 
…ect#16809)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@windsonsea
[Docs] Fix a link and grammar issue in production-stack.md (vllm-proj…
6f76ae3 
…ect#16809)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@windsonsea @lk-chen
[Docs] Fix a link and grammar issue in production-stack.md (vllm-proj…
131a7d7 
…ect#16809)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@windsonsea @adobrzyn
[Docs] Fix a link and grammar issue in production-stack.md (vllm-proj…
68b6cb1 
…ect#16809)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@windsonsea
[Docs] Fix a link and grammar issue in production-stack.md (vllm-proj…
5a501a6 
…ect#16809)

Signed-off-by: windsonsea <haifeng.yao@daocloud.io>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
@windsonsea windsonsea deleted the helmsh branch July 3, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@windsonsea @DarkLight1337