Improve configs - MultiModalConfig + PoolerConfig + DecodingConfig#16789
Merged
vllm-bot merged 5 commits intovllm-project:mainfrom Apr 18, 2025
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
DarkLight1337,
robertgshaw2-redhat,
simon-mo and
ywang96
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
mergify
bot
added
documentation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
| "--dtype=bfloat16", "--max-model-len=4096", "--enforce-eager", | ||
| f'--limit-mm-per-prompt={{"audio":{len(audio_assets)}}}', | ||
| "--trust-remote-code" | ||
| f"--limit-mm-per-prompt='{limit_mm_per_prompt}'", "--trust-remote-code" |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
DarkLight1337
approved these changes
Apr 17, 2025
github-actions
bot
added
the
ready
hmellor
changed the title
MultiModalConfig + PoolerConfig + DecodingConfig
yangw-dev
pushed a commit
to yangw-dev/vllm
that referenced
this pull request
Apr 21, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Yang Wang <elainewy@meta.com>
This was referenced Apr 22, 2025
1 task
jikunshang
pushed a commit
to jikunshang/vllm
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Apr 29, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
adobrzyn
pushed a commit
to HabanaAI/vllm-fork
that referenced
this pull request
Apr 30, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu
pushed a commit
to RichardoMrMu/vllm
that referenced
this pull request
May 12, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #16332, #16422, #16533, #16603
Notable changes:
--limit-mm-per-promptmoves away from the customnullable_kvstype in preference to JSON strings (which are used for all other mapping inputs)nullable_kvswill still work as a fallback with a warning during the transition period