👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Hey @robertgshaw2-redhat, I assume this check was intentional. Can you take a look?

@robertgshaw2-redhat hi, may I ask for your review? we test V1 engine with additional_config. It works well. Anything I missed?

Good by me. I was not sure what this was for, so I disabled out of an abundance of caution.

Thanks for the PR!

Test failure with lora error. Looks doesn't relate to this PR