Skip to content

[ROCm] [Attention] Cleanup ROCm output passing#16431

Merged
mgoin merged 4 commits intovllm-project:mainfrom
neuralmagic:luka/rocm-attn-output
Apr 18, 2025
Merged

[ROCm] [Attention] Cleanup ROCm output passing#16431
mgoin merged 4 commits intovllm-project:mainfrom
neuralmagic:luka/rocm-attn-output

Conversation

@ProExpertProg
Copy link
Collaborator

@ProExpertProg ProExpertProg commented Apr 10, 2025 •
edited by github-actions bot
Loading

This PR cleans up the many copies & reallocations of outputs in the ROCm attention backend. This is needed for the attention+quant fusion described in #16220.

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ProExpertProg
Cleanup ROCm output passing
1d14709 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
@ProExpertProg ProExpertProg force-pushed the luka/rocm-attn-output branch from 05e95a8 to 1d14709 Compare April 10, 2025 20:40
rasmith
rasmith reviewed Apr 11, 2025
View reviewed changes
rasmith
rasmith reviewed Apr 11, 2025
View reviewed changes
rasmith
rasmith reviewed Apr 11, 2025
View reviewed changes
@ProExpertProg
Fix output for ROCm FA output
1db78f0 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
@ProExpertProg
Fix sdpa arg type
38f95b1 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
@ProExpertProg
Remove out param from FA path
f0b63ee 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
@ProExpertProg ProExpertProg mentioned this pull request Apr 17, 2025
Merged
mgoin
mgoin approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@mgoin mgoin added rocm Related to AMD ROCm ready ONLY add when PR is ready to merge/full CI is needed labels Apr 17, 2025
@mgoin mgoin enabled auto-merge (squash) April 17, 2025 17:00
@mgoin mgoin merged commit aaec845 into vllm-project:main Apr 18, 2025
62 checks passed
@ProExpertProg ProExpertProg deleted the luka/rocm-attn-output branch April 18, 2025 06:02
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@ProExpertProg @yangw-dev
[ROCm] [Attention] Cleanup ROCm output passing (vllm-project#16431)
9e8d24e 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@ProExpertProg
[ROCm] [Attention] Cleanup ROCm output passing (vllm-project#16431)
973fdb2 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@ProExpertProg @lk-chen
[ROCm] [Attention] Cleanup ROCm output passing (vllm-project#16431)
bf9084c 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@ProExpertProg @adobrzyn
[ROCm] [Attention] Cleanup ROCm output passing (vllm-project#16431)
3cc17d1 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@ProExpertProg
[ROCm] [Attention] Cleanup ROCm output passing (vllm-project#16431)
cacba1f 
Signed-off-by: Luka Govedič <lgovedic@redhat.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

+2 more reviewers

@rasmith rasmith rasmith approved these changes

@shajrawi shajrawi shajrawi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ProExpertProg @rasmith @mgoin @shajrawi