Skip to content

to update python code for clean code#179

Merged
minjk-bl merged 4 commits into
visualpython:oss22_libraryfrom
Minku-Koo:osskoo
Sep 19, 2022
Merged

to update python code for clean code#179
minjk-bl merged 4 commits into
visualpython:oss22_libraryfrom
Minku-Koo:osskoo

Conversation

@Minku-Koo

Copy link
Copy Markdown
Contributor

to update python code for clean code

  • remove unnecessary variable
  • remove unnecessary conditions
  • convert to list comprehension
  • add 'return' to indicate the end of method
  • etc

Remove unnecessary conditions
Update for Clean Code
- add 'return' to indicate the end of method
- add a line break after a condition statement
Update for Clean Code
- move 'import' to the top
- convert to list comprehension
Update for Clean Code
- convert duplicated conditions to one line
- remove unnecessary variable in loop
@minjk-bl minjk-bl merged commit f126071 into visualpython:oss22_library Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants