User data rework #336
Draft
User data rework #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metadata is quite tangled with this class, so ensure test coverage before rework
goneri
reviewed
Jul 16, 2025
| @@ -0,0 +1,37 @@ | |||
| class Userdata: | |||
Member
There was a problem hiding this comment.
Nice work. This could be a good candidate for a @DataClass https://docs.python.org/3/library/dataclasses.html
Collaborator
Author
There was a problem hiding this comment.
It is very early stage for now, but dataclass looks good for this place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make user data more structured