add default feature set of some features #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we look at https://xdebug.org/docs/dbgp#options-and-configuration in the feature names we see any dbgp debugger must provide some feature set by default. Even if that feature is not actually supported. So from now on we will set multiple_sessions = 0 because Vdebug does not support this at the moment and we will try to set extended_properties = 1; if the used debugger does not support it we will silently continue without the feature. fixes #369 Signed-off-by: BlackEagle <ike.devolder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we look at https://xdebug.org/docs/dbgp#options-and-configuration in
the feature names we see any dbgp debugger must provide some feature set
by default. Even if that feature is not actually supported.
So from now on we will set multiple_sessions = 0 because Vdebug does not
support this at the moment and we will try to set extended_properties =
1; if the used debugger does not support it we will silently continue
without the feature.
fixes #369
Signed-off-by: BlackEagle ike.devolder@gmail.com