fix: make TestNearest search both directions for zig - #903
Merged
Conversation
Collaborator
|
Thank you for this! Could you please update the spec for this? It should just be a case of adding another example for |
Contributor
Author
|
Sure thing!
EDIT: on second thought, that's a separate issue that does not clash with this change, it'll be addressed in a follow-up PR. |
codeinabox
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before submitting your pull request:
doc/test.txtI'm not sure if this is on anyone's wishlist, but I found it odd that
TestNearestbehaved likeTestFilewhen there were no tests above the current line. This PR makes it run the nearest test below in case it finds no tests upwards, which is what I'd expect from the Nearest in the name, and if somebody actually wanted to run all of the tests then there'sTestFile.This is now probably an inconsistency compared to other test runners, but I haven't used any of them so...
In any case, I'd rather have this closed (but not deleted) in case somebody has the same itch than not having it published anywhere at all.