Add filetype support for WebAssembly text format#3264
Closed
rhysd wants to merge 2 commits intovim:masterfrom
Closed
Add filetype support for WebAssembly text format#3264rhysd wants to merge 2 commits intovim:masterfrom
rhysd wants to merge 2 commits intovim:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3264 +/- ##
==========================================
- Coverage 76.57% 76.55% -0.03%
==========================================
Files 93 93
Lines 136843 136839 -4
==========================================
- Hits 104793 104755 -38
- Misses 32050 32084 +34
Continue to review full report at Codecov.
|
Contributor
|
Linda wrote:
## Problem
Vim does not support [WebAssembly text format][spec]
## Solution
This PR adds support for the WebAsembly text format to Vim.
WebAssembly is a new executable format for browsers. Since WebAssembly spec is defined by [W3C](https://www.w3.org/community/webassembly/), the spec is one of long live web standards.
https://webassembly.org/
I had created a project [vim-wasm](https://github.com/rhysd/vim-wasm) to support the text format. And today, I refined it following [WebAssembly Spec][spec]. Now it can highlight the text format very well.
This is an example of highlighting using my project [vim.wasm](https://github.com/rhysd/vim.wasm):
<img width="424" alt="highlighting example" src="https://user-images.githubusercontent.com/823277/43366973-8377bdf8-9380-11e8-8ca7-a912768e6e10.png">
[spec]: https://webassembly.github.io/spec/core/text/index.html
Thanks for working on this.
In the indent file you set the 'lisp' option. This has side effects.
Instead, I would recommend to use the lispindent() function. Unless the
side effects are actually desired.
In the syntax file I would recomment setting 'cpo', like it's done in
many. Even when you don't use line continuation, it also affects some
details about regexp pattern matching.
…--
You know you use Vim too much when you have this alias in your
~/.bashrc file: alias :e=/bin/vim (Eljay Love-Jensen)
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
Contributor
Author
Contributor
|
I'll include it, thanks. It would be nice to have your full name for the Maintainer line. |
Contributor
Author
|
Thank you. I'll wait for the changes being included.
Yeah, I considered that, but I'm basically not making my full name public on the Internet. When my mind changes, I'll send a patch to update the 'Maintainer:' lines. Thank you for your suggestion. |
Contributor
Author
|
I confirmed these changes were included in master branch. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Vim does not support WebAssembly text format
Solution
This PR adds support for the WebAsembly text format to Vim.
WebAssembly is a new executable format for browsers. Since WebAssembly spec is defined by W3C, the spec is one of long live web standards.
https://webassembly.org/
I had created a project vim-wasm to support the text format. And today, I refined it following WebAssembly Spec. Now it can highlight the text format very well.
This is an example of highlighting using my project vim.wasm: