Skip to content

Make popup image feature optional for now - #21017

Draft
64-bitman wants to merge 1 commit into
vim:masterfrom
64-bitman:image_opt
Draft

Make popup image feature optional for now#21017
64-bitman wants to merge 1 commit into
vim:masterfrom
64-bitman:image_opt

Conversation

@64-bitman

@64-bitman 64-bitman commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

I don't think the popup image feature is ready for mainstream use as of now.

  • Kitty graphics protocol backend is designed wrong
  • clipwindow property of popup images does not work well with images
  • Clipping of images does not behave as expected
  • Possibly other bugs

I plan on adding tests later:

  • GTK4 GUI we can use the existing GTK4 infastructure for comparing render nodes. This should be feasible.
  • For Kitty graphics protocol and sixel, we could possibly run a graphical terminal in a headless kiosk Wayland compositor (e.g. cage), take a screenshot of the output, and compare to an existing image with ImageMagick. Same with GTK3 GUI. Not sure if this will actually work however
  • Not sure about MS-Windows (GDI), but it should be very similar to the GTK3 GUI in how its implemented. So not having tests shouldn't be too big of a deal.

@chrisbra

Copy link
Copy Markdown
Member

thanks, let's mark it as draft for now.

@chrisbra
chrisbra marked this pull request as draft August 12, 2026 19:03
@chrisbra

Copy link
Copy Markdown
Member

I also think making this feature optional is the right thing to do here, so I would be also fine if we just merge the configure changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants