Make popup image feature optional for now - #21017
Draft
64-bitman wants to merge 1 commit into
Draft
Conversation
Member
|
thanks, let's mark it as draft for now. |
chrisbra
marked this pull request as draft
August 12, 2026 19:03
Member
|
I also think making this feature optional is the right thing to do here, so I would be also fine if we just merge the configure changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think the popup image feature is ready for mainstream use as of now.
clipwindowproperty of popup images does not work well with imagesI plan on adding tests later:
cage), take a screenshot of the output, and compare to an existing image with ImageMagick. Same with GTK3 GUI. Not sure if this will actually work however