Patching of if_lua.c for lua 5.5 compatibilty#19842
Open
lyderic wants to merge 3 commits intovim:masterfrom
Open
Patching of if_lua.c for lua 5.5 compatibilty#19842lyderic wants to merge 3 commits intovim:masterfrom
lyderic wants to merge 3 commits intovim:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #19814: Lua interface broken after Lua 5.5 upgrade (on Linux).
I used AI. I submitted the problem to OpenCode Zen and this is what it found:
Lua 5.5 renamed the function
luaL_openlibstoluaL_openselectedlibs. The vim source code insrc/if_lua.cstill references the old function name:# define luaL_openlibs dll_luaL_openlibsvoid (*dll_luaL_openlibs) (lua_State *L);{"luaL_openlibs", (luaV_function) &dll_luaL_openlibs},luaL_openlibs(L); // core libsVerification via nm confirms the symbol doesn't exist in Lua 5.5:
$ nm -D /usr/lib/liblua.so.5.5.0 | grep luaL_openlibs (nothing returned - symbol renamed)OpenCode Zen patched
if_lua.cand added conditions to test the lua version. I tried the patch on two configurations I have and it was successful:I couldn't test on other configurations, in particular MacOS, Windows, BDS, Linux ARM etc.