Store virtual text in ref-counted vtext_T to fix undo/redo#19836
Open
h-east wants to merge 1 commit intovim:masterfrom
Open
Store virtual text in ref-counted vtext_T to fix undo/redo#19836h-east wants to merge 1 commit intovim:masterfrom
h-east wants to merge 1 commit intovim:masterfrom
Conversation
Problem: Virtual text stored in b_textprop_text is not part of the
undo/redo mechanism, causing text mismatch after undo when
IDs are recycled. The b_textprop_text growarray also grows
indefinitely with repeated add/remove.
Solution: Add vtext_T with reference counting and store the pointer
directly in textprop_T.tp_vtext. Remove b_textprop_text.
Increment refcount when saving lines for undo, decrement
when undo entries are freed. Virtual text memory is now
managed per-property and freed when refcount reaches zero.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Virtual text stored in b_textprop_text is not part of the
undo/redo mechanism, causing text mismatch after undo when
IDs are recycled. The b_textprop_text growarray also grows
indefinitely with repeated add/remove.
Solution: Add vtext_T with reference counting and store the pointer
directly in textprop_T.tp_vtext. Remove b_textprop_text.
Increment refcount when saving lines for undo, decrement
when undo entries are freed. Virtual text memory is now
managed per-property and freed when refcount reaches zero.
Fixes: #19680
Fixes: #19681