Fix: memory leak in call_oc_method in src/vim9class.c#19828
Open
huanghuihui0904 wants to merge 1 commit intovim:masterfrom
Open
Fix: memory leak in call_oc_method in src/vim9class.c#19828huanghuihui0904 wants to merge 1 commit intovim:masterfrom
call_oc_method in src/vim9class.c#19828huanghuihui0904 wants to merge 1 commit intovim:masterfrom
Conversation
Signed-off-by: huanghuihui0904 <625173@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
call_oc_method()located insrc/vim9class.c,get_func_arguments()is called at line 3100 to parse and evaluate function arguments intoargvars[]. Whenget_func_arguments()fails, it may have already populatedargvars[0..argcount-1]with evaluated arguments that own allocated memory (e.g., strings, lists, dicts).The function returns FAIL immediately without cleaning up these arguments:
The cleanup loop at lines 3126-3127 is only reached on the success path:
Other callers of
get_func_arguments()(e.g.,get_func_tv()insrc/userfunc.c:2209-2210) correctly clean upargvarson both success and failure paths.Solution
Clean up the already-parsed arguments before returning FAIL, matching the pattern used in
get_func_tv(). The fix is included in the commit.