Port socketserver to use channels and JSON based protocol#19782
Draft
64-bitman wants to merge 19 commits intovim:masterfrom
Draft
Port socketserver to use channels and JSON based protocol#1978264-bitman wants to merge 19 commits intovim:masterfrom
64-bitman wants to merge 19 commits intovim:masterfrom
Conversation
64-bitman
force-pushed
the
socketserver_channel
branch
5 times, most recently
from
d9aeb75 to
b4fca02
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
64-bitman
force-pushed
the
socketserver_channel
branch
6 times, most recently
from
602d848 to
a203698
Compare
Contributor
Author
|
@pemensik Can you test if this PR fixes your issue? Thanks |
|
Note: JSON has a binary alternative in standardized CBOR protocol. It might be better suited for some binary blobs exchange. It can even represent JSON. |
64-bitman
force-pushed
the
socketserver_channel
branch
from
a4ee703 to
5e8e11c
Compare
Contributor
Author
Well there is no need to exchange binary blobs so JSON works fine |
64-bitman
force-pushed
the
socketserver_channel
branch
4 times, most recently
from
b64f04e to
cdfd587
Compare
64-bitman
force-pushed
the
socketserver_channel
branch
from
cdfd587 to
b620090
Compare
64-bitman
force-pushed
the
socketserver_channel
branch
from
b620090 to
e5ea406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not backwards compatible with the old protocol, but I think it is worth it. Using JSON is much simpler instead of trying to understand some arcane custom binary protocol.