Allow virtual text to overlay buffer text#19661
Open
64-bitman wants to merge 5 commits intovim:masterfrom
Open
Allow virtual text to overlay buffer text#1966164-bitman wants to merge 5 commits intovim:masterfrom
64-bitman wants to merge 5 commits intovim:masterfrom
Conversation
3b6a9b1 to
5526770
Compare
8e29531 to
a60e2ff
Compare
fc7942c to
ac3576d
Compare
ac3576d to
4d29f70
Compare
Contributor
Author
|
I will put this PR on hold until #19685 is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15007
Should work correctly with multibyte and double width characters. If the overlay text can't fully cover a double width character, then a '>' will be substituted in.
If the overlay is placed over double-width characters, then the cursor will appear to skip some characters. I initially thought this was a bug, however it seems like Neovim has the same behaviour. Thinking about it more, it makes sense.
Here is a demo program to test