avoid overwriting right-top corner when drawing top border#19299
Open
mattn wants to merge 5 commits intovim:masterfrom
Open
avoid overwriting right-top corner when drawing top border#19299mattn wants to merge 5 commits intovim:masterfrom
mattn wants to merge 5 commits intovim:masterfrom
Conversation
Member
|
Hm, if you inspect the dump files, this looks slightly wrong: Now it seems the border is drawn 1 char too short? |
mattn
force-pushed
the
fix-popup-right-corner
branch
from
138ffdd to
6cc52d3
Compare
Member
Author
|
I updated patch. I want to test with same dump file. Which dump file do you use? |
When a popup window's border overwrites part of a wide character from another popup, the remaining half should preserve its original attribute (background color) instead of being reset to 0. The fix modifies screen_fill() to save and use the existing ScreenAttrs value when clearing wide character boundaries, rather than using attr=0.
mattn
force-pushed
the
fix-popup-right-corner
branch
from
139d39f to
bc94bc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When drawing the top border of a popup window, screen_fill() was called with wincol + total_width as the end column, which caused it to overwrite the right-top corner character (border_char[5]) that is placed at wincol + total_width - 1. The overwritten character would display with attr=0 (default background), appearing as black.
So, change the end column from wincol + total_width to wincol + total_width - 1, so that screen_fill() does not overwrite
the right-top corner character. This fix applies to all popup windows, including those using multibyte
characters for borders.