Prevent overwriting editing keys with keypad keys#19181
Draft
AstroSnail wants to merge 1 commit intovim:masterfrom
Draft
Prevent overwriting editing keys with keypad keys#19181AstroSnail wants to merge 1 commit intovim:masterfrom
AstroSnail wants to merge 1 commit intovim:masterfrom
Conversation
Problem: In XTerm, with 'xtermcodes' enabled (default), when the user
presses <Home> vim will see <kHome>. This affects `:map`pings
and `:terminal`, which care whether a keypress was <Home> or
<kHome>.
Cause: Vim requests termcodes for keys like <Home>, <End>, <PageUp>,
<PageDown>, and their keypad counterparts <kHome>, etc. If
XTerm replies with the same termcode for <Home> and <kHome>,
vim will only keep <kHome> because it is requested after
<Home>.
Solution: When a termcode reply is a keypad key and it would replace a
different key, skip it.
Signed-off-by: AstroSnail <astrosnail@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested fix for #17331, alternative to #19145. In principle there is no conflict with the other fix.
An advantage of this fix over #19145 is that it doesn't rely on the builtin
<xHome>. Instead, vim will associate the correct termcode with<Home>.The test fails because
<PageUp>and<PageDown>are still not fixed. Fixing those requires improvingfind_term_bykeysto recognize that^[[5;*~is a match for^[[5~. If the maintainers are interested I can try doing such an improvement and un-draft this PR.