Improve test_codestyle whitespace testing #18599
Draft
+60
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-east
approved these changes
Oct 18, 2025
dkearns
force-pushed
the
fix-help-code-style-exception
branch
from
5c27006 to
144d35d
Compare
|
It might be better to explicitly match the existing exceptions for the trailing whitespace test ( |
dkearns
force-pushed
the
fix-help-code-style-exception
branch
4 times, most recently
from
365133a to
f8038ce
Compare
dkearns
force-pushed
the
fix-help-code-style-exception
branch
from
f8038ce to
ddf813f
Compare
Problem: test_codestyle does not catch all unintended whitespace violations in help files. Solution: Improve the relevant patterns. - Don't require a character [^/] before <Space><Tab> so we can match this at the start of a line. - Fix the pattern test for the exception at :help 27.6, this was matching the pattern /[^? ^I]/ rather than the literal text and skipping most of the file. - Add specific test exceptions for all necessary violations. - Use PerformCheck() to process line checks. - Convert file to Vim9 script. Signed-off-by: Doug Kearns <dougkearns@gmail.com>
dkearns
force-pushed
the
fix-help-code-style-exception
branch
from
ddf813f to
1a9340b
Compare
chrisbra
reviewed
Oct 29, 2025
| # break | ||
| # endif | ||
| # endwhile | ||
| # PerformCheck('\%>80v.*$', 'line over 80 columns') |
There was a problem hiding this comment.
We could use a skip expression here, so that we don't report errors for overlong lines in helpExamples. Something like this seems to work:
diff --git a/src/testdir/test_codestyle.vim b/src/testdir/test_codestyle.vim
index 46f839c06..d639b8c7d 100644
--- a/src/testdir/test_codestyle.vim
+++ b/src/testdir/test_codestyle.vim
@@ -107,6 +107,7 @@ enddef
def Test_help_files()
var lnum: number
set nowrapscan
syn on
for fpath in glob('../../runtime/doc/*.txt', 0, 1)
g:ignoreSwapExists = 'e'
@@ -151,15 +152,14 @@ def Test_help_files()
endif
endwhile
cursor(1, 1)
while 1
lnum = search('\%>80v.*$', '', 0, 0, () => synIDattr(synID(line("."), col("."), 1), "name") =~# 'helpExample')
ReportError(fpath, lnum, 'line over 80 columns')
if lnum == 0
break
endif
endwhile
It still reports 296 matches with overlong lines :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: test_codestyle does not catch all unintended whitespace violations in help files.
Solution: Improve the relevant patterns.
[^/]before<Space><Tab>so we can match this at the start of a line.:help 27.6, this was matching the pattern/[^? ^I]/rather than the literal text and skipping most of the file.PerformCheck()to process line checks.