fix(pum): restore cursor position after preinserting multiline match #18082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When a match containing multiple lines is preinserted, the cursor position becomes incorrect. Solution: Record the cursor position after inserting the match, and restore the original position after displaying the popup menu.
|
@glepnir I have tested this pr. But it haven't fix the problem. It just reset the cursor position to first char pos instead of respecting input char like single item. Screen.Recording.2025-08-22.161248.mp4 |
|
forget new leader update later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a match containing multiple lines is preinserted, the cursor position becomes incorrect.
Solution:
Record the cursor position after inserting the match, and restore the original position after displaying the popup menu.
Fix #18081