fix(vimeo): report correct muted state in auto-play event#1745
Open
jtomaszewski wants to merge 2 commits intovidstack:mainfrom
Open
fix(vimeo): report correct muted state in auto-play event#1745jtomaszewski wants to merge 2 commits intovidstack:mainfrom
jtomaszewski wants to merge 2 commits intovidstack:mainfrom
Conversation
- `?src=vimeo|youtube|hls|video|audio|live|dash` - select source - `?autoplay` - enable autoplay - `?muted` - start muted - Logs `auto-play` and `auto-play-fail` events to console
When browser forces muting due to autoplay policy, the auto-play event now correctly reports muted: true instead of false. - Add getMuted/getVolume command types to Vimeo provider - Await getMuted before notifying play event in #onPlay and #onWaiting - This ensures muted state is synced before auto-play event fires
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto-playevent now correctly reportsmuted: truewhen browser enforces mutingProblem
When autoplay succeeds on Vimeo embeds but the browser forces muting due to autoplay policy, the
auto-playevent was incorrectly reportingmuted: false.Solution
Query Vimeo's actual muted state via
getMutedAPI before notifying the play event. This ensures the muted state is synced before the synchronousauto-playevent fires.Changes
getMutedcommand type to Vimeo providergetMutedin#onPlayand#onWaitingbefore notifying play eventTest
Open in incognito window → console shows
[auto-play] { muted: true }Note
This PR is based on #1744 which adds URL params support to the sandbox.
🤖 Generated with Claude Code