feat(sandbox): add URL params support for testing#1744
Open
jtomaszewski wants to merge 1 commit intovidstack:mainfrom
Open
feat(sandbox): add URL params support for testing#1744jtomaszewski wants to merge 1 commit intovidstack:mainfrom
jtomaszewski wants to merge 1 commit intovidstack:mainfrom
Conversation
- `?src=vimeo|youtube|hls|video|audio|live|dash` - select source - `?autoplay` - enable autoplay - `?muted` - start muted - Logs `auto-play` and `auto-play-fail` events to console
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?src=vimeo|youtube|hls|video|audio|live|dash- select source?autoplay- enable autoplay?muted- start mutedauto-playandauto-play-failevents to consoleWhy add this?
This helps testing (and thus developing) features such as autoplay. I need that to make another issue apparent, for which I'll create a PR shortly. If interested, see its' description below.
Known Issue - Vimeo Autoplay Muted State
This PR also makes a bug in the Vimeo provider visible: when a video starts with autoplay, it may be muted by the browser (due to Chrome's autoplay policy), yet the player UI shows it as unmuted.
Repro: Visit
http://localhost:3100/sandbox/index.html?src=vimeo&autoplayIssue: Vidstack's
onAutoPlayevent reportsmuted: falseeven when Chrome forces the Vimeo iframe to mute due to autoplay policy.Root cause: For Vimeo iframe embeds, Chrome's autoplay policy applies inside the iframe and Vimeo handles muting internally. Vidstack reports its own requested state (
muted: false, volume: 1), not what Vimeo actually did.Expected behavior: Either: