fix(text-track): normalize whitespace in content before parsing #1716
+413
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Fixes SRT subtitle parsing issues where comma-separated milliseconds (e.g.,
00:00:01,000) fail to parse when content contains indented template literals.Closes #1671
Description:
This PR adds whitespace normalization to the
#parseContentmethod inTextTrackto handle indented template literal content before passing it to themedia-captionsparser.Changes:
content.split('\n').map(line => line.trim()).join('\n').trim()to normalize whitespace while preserving line structureProblem Solved:
The
media-captionslibrary expects clean content without leading/trailing whitespace. When using template literals with indentation for inline SRT content, the parser would fail with errors like"cue start timestamp \'00:00:00,000\' is invalid"even though the SRT format itself was correct.Ready?
✅ Yes - All tests passing, edge cases covered, and backward compatibility maintained.
Anything Else?
Before (Failed):
After (Works)
Test Results: ✅ 16/16 tests passing
\r\n), extreme indentationDetailed Coverage:
\r\n) compatibility00:00:01,000) parsing00:00:01.000) parsingManual Test Scenarios:
Template Literal Testing
Cross-platform Line Endings
JSON Content Bypass
VTT Format Testing
Edge Case Validation