Add debounce operator#308
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 98.09% 97.87% -0.23%
==========================================
Files 110 112 +2
Lines 1631 1694 +63
==========================================
+ Hits 1600 1658 +58
- Misses 31 36 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
BENCHMARK RESULTS (AUTOGENERATED)ci-macosObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
on_error_resume_nextTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
timeoutTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-ubuntu-clangObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
on_error_resume_nextTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
timeoutTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-ubuntu-gccObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
on_error_resume_nextTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
timeoutTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-windowsObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
on_error_resume_nextTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
timeoutTable
trampoline schedulerTable
windowTable
with_latest_fromTable
|
| schedulers::duration period, | ||
| const Scheduler& scheduler, | ||
| const composite_subscription& subscription_of_subscriber) | ||
| : debounce_state<T, Scheduler>{std::move(period), scheduler, subscription_of_subscriber} |
Contributor
There was a problem hiding this comment.
std::move of the variable period of the trivially-copyable type schedulers::duration (aka duration<long, ratio<1, 1000000000>>) has no effect; remove std::move()
Suggested change
| : debounce_state<T, Scheduler>{std::move(period), scheduler, subscription_of_subscriber} | |
| : debounce_state<T, Scheduler>{eriod), scheduler, subscription_of_subscriber} |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Resolves #306