Skip to content

Optimize installation experience on windows - #6

Merged
aooohan merged 2 commits into
mainfrom
dev
Apr 25, 2024
Merged

aooohan merged 2 commits into
mainfrom
dev

Conversation

@zealcc

@zealcc zealcc commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@zealcc
zealcc requested a review from aooohan April 24, 2024 09:32

@aooohan aooohan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you so much for such a great contribution! 馃憤馃憤馃憤

I will test it on Windows later.

Comment thread lib/util.lua Outdated
@zealcc
zealcc force-pushed the dev branch 2 times, most recently from d21c93f to f2b2858 Compare April 24, 2024 10:29
@zealcc
zealcc requested a review from aooohan April 24, 2024 10:30

@aooohan aooohan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Test passed!

@aooohan
aooohan merged commit 5b1f24c into main Apr 25, 2024
@aooohan
aooohan deleted the dev branch April 25, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants