fix: preserve Windows installer paths with spaces and shell characters - #47
Merged
Merged
Conversation
Keep the Windows integration fixture on the user volume so plugin staging can finish before installer validation. Fixes version-fox/vfox#685
Preserve UTF-8 paths and exit status through GopherLua and cmd.exe without nested command quotes. Fixes version-fox/vfox#685
Report each MSI package and capture process diagnostics if the Windows integration install stalls. Fixes version-fox/vfox#685
Install percent-containing destinations through a temporary junction and remove only the link after MSI exits. Verify the real installation path and junction cleanup on Windows CI. Fixes version-fox/vfox#685
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve Windows paths across WiX extraction, MSI installation, pip setup, and command aliases using encoded PowerShell commands. Stop on failed or empty MSI enumeration. For percent-containing destinations, extract through a temporary junction to avoid Windows Installer expanding the path internally, then remove only the junction.
Validation: Windows CI on 4c69191 installed official Python 3.14.5 through WiX and seven MSI packages into a path containing spaces, an apostrophe, ampersand, percent variables, and an exclamation mark. Python, pip, all three aliases, venv, exact destination, and junction cleanup assertions passed. A TEMP path containing percent signs is explicitly rejected.
Fixes version-fox/vfox#685