feat: add tanstack support #159
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| @@ -0,0 +1,152 @@ | |||
| import { createFileRoute } from '@tanstack/react-router'; | |||
| import { allWorkflows } from '_workflows.js'; | |||
There was a problem hiding this comment.
| import { allWorkflows } from '_workflows.js'; | |
| import { allWorkflows } from '../../../_workflows.js'; |
The import statement uses a bare module name '_workflows.js' that cannot be resolved. This should use a relative path to the _workflows.ts file at the project root.
View Details
Analysis
Incorrect bare module import in workbench/tanstack/src/routes/api/trigger.ts fails module resolution
What fails: The import statement on line 2 of workbench/tanstack/src/routes/api/trigger.ts uses a bare module name '_workflows.js' that cannot be resolved by TypeScript or Node.js module resolution.
How to reproduce:
cd workbench/tanstack
pnpm exec tsc src/routes/api/trigger.ts --noEmitResult: TypeScript error TS2307: Cannot find module '_workflows.js' or its corresponding type declarations.
Expected: Import should use a relative path to the _workflows.ts file located at the root of the workbench. Since the file is at src/routes/api/trigger.ts and _workflows.ts is at the root, the correct path is ../../../_workflows.js (three levels up: api/ → routes/ → src/ → root).
This matches the pattern used in other workbenches where similar route handlers import _workflows using relative paths (e.g., workbench/hono/server.ts uses ./_workflows.js, workbench/nitro-v2/server/api/trigger.post.ts uses ../_workflows.js).
adriandlam
force-pushed
the
feat/tanstack-support
branch
from
4a2f2b3 to
20477c3
Compare
No description provided.