fix(cli): harden env pull file permissions#16331
Open
wesleysimplicio wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 7509968 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vercel env pullwrites managed.env*files without explicitly restricting file permissions. On POSIX systems that commonly lands as group/world-readable depending on umask, which is not a great default for secrets downloaded by the CLI.Root cause
The command writes env files with
outputFile(fullPath, contents, 'utf8')and never reapplies a restricted mode after writing.Fix
mode: 0o600chmod(0o600)so already-existing CLI-managed files are hardened toovercelSolution sketch
flowchart TD A[env pull downloads secrets] --> B[write managed env file] B --> C[set mode 0o600 on create] C --> D{POSIX platform?} D -- no --> E[finish] D -- yes --> F[chmod file to 0o600] F --> EDuplicate check
#16312and#16136; they touch nearby CLI surface but not this permission hardening behaviorenv pulloutput file mode to0600Tests
Attempted:
corepack pnpm test test/unit/commands/env/pull.test.tsEnvironment note:
node_modules, sovitestis not available in this environment and the test command could not complete hereAdded focused test coverage in:
packages/cli/test/unit/commands/env/pull.test.tsRisk
Low. The change only affects files created or rewritten by
env pull, and the intent matches existing secure defaults already used elsewhere for sensitive CLI material.