Open
Conversation
Houzvicka
force-pushed
the
feature/splashScreenImprovmenets
branch
from
d6d106d to
4bdd5f4
Compare
Member
|
This looks like a reasonable and well done change. Thanks very much for submitting. I'll do some testing! One nitpick would be: I feel like the CLI option should be more clear that it's related to the splash screen. e.g. |
Author
|
@caesay I try to implement your suggestions :) You can check it in latest commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After migrating from Squirrel, I realized that Velopack has always had a background under the splash screen.
This PR fixes that by enabling true transparency, and also adds options to hide or change the color of the progress bar.
The changes to splash screen rendering for transparency also improve DPI handling. (#633 , #236 )