Fix: Exclude packages without channel metadata from channel-specific feed requests#747
Open
prpercival wants to merge 1 commit intovelopack:developfrom
Open
Fix: Exclude packages without channel metadata from channel-specific feed requests#747prpercival wants to merge 1 commit intovelopack:developfrom
prpercival wants to merge 1 commit intovelopack:developfrom
Conversation
…requests When GetReleaseFeed() is called with a specific channel, packages without channel metadata (Channel == null) are now excluded from the results. Previously, these packages were included in all channel-specific requests, causing issues during Squirrel migrations where legacy packages would appear as valid releases on any channel. This change ensures that: - Channel-specific requests only return packages explicitly tagged with that channel - Requests without a specific channel (channel == null) still return all packages - Legacy packages without channel metadata are properly isolated from channel-specific update checks Fixes issue where legacy packages could cause unintended downgrades when AllowVersionDowngrade is enabled.
Author
|
Issue for PR: #747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where packages without channel metadata (
zip.Channel == null) are incorrectly included in channel-specific feed requests. This primarily affects migration scenarios from Clowd.Squirrel where legacy packages lack channel information.Problem
The current logic in
SimpleFileSource.GetReleaseFeed()treats packages without channel metadata as matching any channel:This means when requesting updates for a specific channel (e.g., "beta"), legacy packages without channel metadata are incorrectly included in the results, potentially causing:
AllowVersionDowngrade = trueSolution
Changed the logic to only include packages with explicit channel matches when a specific channel is requested:
Testing
Have not tested locally, but the logic is pretty straightforward.
Breaking Changes
Not sure if there is any background as to why this exists the way it does, would have to have a more active maintainer chime in on any breaking changes.