chore(dev): add opentelemetry traces e2e tests #24118
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: ci
thomasqueirozb
added
the
no-changelog
pront
reviewed
Oct 30, 2025
pront
reviewed
Nov 3, 2025
| inputs: | ||
| - source0.traces | ||
| encoding: | ||
| codec: json |
There was a problem hiding this comment.
Suggested change
| codec: json | |
| codec: otlp |
if you did the above, would it eliminate the need for decode_span_id?
pront
reviewed
Nov 3, 2025
| /// The collector outputs IDs as hex strings (e.g., "804ab72eed55cea1"), | ||
| /// Vector outputs as base64 (standard JSON encoding for binary fields). | ||
| /// Works for both span_id (8 bytes) and trace_id (16 bytes). | ||
| fn decode_span_id(id: &[u8]) -> Vec<u8> { |
There was a problem hiding this comment.
If this https://github.com/vectordotdev/vector/pull/24118/files#r2487430711 doesn't work for whatever reason (e.g. we prefer to write as JSON for easier debugging), the problem with this function is that it's doing too much. Instead you can have decode_base64_id and decode_hex_id.
pront
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.