Rename library-portal to library, swap Stirling-PDF for BentoPDF, fix distribution repo-root bug - #3
Merged
Merged
Conversation
… distribution repo-root bug - Rename the "library-portal" app to "library" throughout (TUI menus, app registry, MCP tool descriptions, docs) - the docker/library-portal/ folder path and its build context are left as-is. - Remove Stirling-PDF entirely (app registry, TUI menus, docs, SECURITY.md threat model) and replace it with BentoPDF's self-hosted build (ghcr.io/alam00000/bentopdf-simple, AGPL-3.0, reuses port 8080). - Fix a real distribution bug: is_valid_repo_root() required a .git directory, which distribute_cli.bat's packaged output never has (it's a plain folder, not a git checkout) - every Docker-app "open" button in a distributed copy failed with "could not locate repository root". Now checks for scripts/ + docker/ instead, which both ship in the distribution. Verified by building a distribution package and running `vn app open library` from it with no .git present - it now reaches the Docker daemon check instead of failing at repo-root detection. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Drops SilverBullet entirely: app registry entry, its plan_for arm, the space-folder backup helper it was the only caller of, the docker.rs "vn docker up silverbullet" special case, TUI Open-menu entries, MCP tool description, and the Silverbullet menu/prompts in both win11 and ubuntu22 main scripts (renumbering the remaining menu choices). Docs (AGENTS.md, SECURITY.md, README.md, docker/README.md, mcp-functions.md, scripts/README.md) updated to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…icons
- docs: mdbook requires SUMMARY.md (book.toml sets src = "."); it was
missing from the port, so mdbook serve failed immediately on start
("Couldn't open SUMMARY.md"). Added one listing README.md and
mcp-functions.md as chapters.
- doc-processor: its Dockerfile copies assets/icons/black-square.svg as
the UI favicon, but assets/ was never carried over during the port, so
the build failed at that COPY step. Added assets/icons/ (the only
assets/ subpath anything references).
Verified both: built and started each container, confirmed docs serves
(page title "Overview - vncli Docs") and doc-processor becomes ready on
its wait_port, then cleaned up the test containers/images.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
library-portalapp tolibraryin everything user-facing (TUI Open menus, app registry, MCP tool descriptions, docs); thedocker/library-portal/folder path is unchanged.ghcr.io/alam00000/bentopdf-simple, AGPL-3.0, reuses port 8080) in its place.is_valid_repo_root()required a.gitdirectory, whichdistribute_cli.bat's packaged output never has - so every Docker-app "open" button failed with "could not locate repository root" (the ".git not found" issue) once distributed. Now checks forscripts/+docker/instead, both of which ship in the distribution.Test plan
cargo build/test/clippy/fmt --checkall passvn app listshowsdocs, silverbullet, bentopdf, library, media-downloader, doc-processordistribute_cli.bat, confirmed no.gitin it, ranvn app open library --no-openfrom inside it - it now reaches the Docker daemon check instead of failing at repo-root detectionworkflow_dispatchCI manually before merging (this repo's CI is manual-only)🤖 Generated with Claude Code