Conversation
dcousens
commented
Apr 28, 2017
| var varbuffer = VarBuffer(lengthType) | ||
| var bufferCodec = VarBuffer(lengthType) | ||
| if (!encoding) encoding = 'utf8' | ||
| if (!Buffer.isEncoding(encoding)) throw new TypeError('invalid encoding') |
Contributor
Author
There was a problem hiding this comment.
IMHO this is not a breaking change, this is a fix
dcousens
commented
Apr 28, 2017
| }, | ||
| encodingLength: function encodingLength (value) { | ||
| if (typeof value !== 'string') throw new TypeError('value must be a string') | ||
| return varbuffer.encodingLength(Buffer.from(value, encoding)) |
Contributor
Author
There was a problem hiding this comment.
my profiler indicated this as the largest performance issue in one of my applications...
This was referenced Apr 28, 2017
fanatid
approved these changes
Apr 28, 2017
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~40% increase in performance when encoding somewhat simple objects