refactor(replace): Replace console.error with throw new Error

colebemis · colebemis · commit 3a3df71e3fdb · 2017-11-04T21:09:13.000-07:00
diff --git a/src/replace.js b/src/replace.js
@@ -32,13 +32,11 @@ function replaceElement(element, options) {
   const key = element.getAttribute('data-feather');
 
   if (!key) {
-    console.error('The required `data-feather` attribute has no value.');
-    return;
+    throw new Error('The required `data-feather` attribute has no value.');
   }
 
   if (!icons[key]) {
-    console.error(`No icon matching '${key}'. See the complete list of icons at https://feathericons.com`);
-    return;
+    throw new Error(`No icon matching '${key}'. See the complete list of icons at https://feathericons.com`);
   }
 
   const elementClassAttr = element.getAttribute('class') || '';

Original file line number	Diff line number	Diff line change
`@@ -32,13 +32,11 @@ function replaceElement(element, options) {`
`32`	`32`	`const key = element.getAttribute('data-feather');`
`33`	`33`
`34`	`34`	`if (!key) {`
`35`		- console.error('The required `data-feather` attribute has no value.');
`36`		`- return;`
	`35`	+ throw new Error('The required `data-feather` attribute has no value.');
`37`	`36`	`}`
`38`	`37`
`39`	`38`	`if (!icons[key]) {`
`40`		- console.error(`No icon matching '${key}'. See the complete list of icons at https://feathericons.com`);
`41`		`- return;`
	`39`	+ throw new Error(`No icon matching '${key}'. See the complete list of icons at https://feathericons.com`);
`42`	`40`	`}`
`43`	`41`
`44`	`42`	`const elementClassAttr = element.getAttribute('class') \|\| '';`