Initial commit 🐢🐢🐢 Feb. 16 #5
Open
+634
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmmc88
reviewed
Feb 20, 2020
Member
wmmc88
left a comment
wmmc88
left a comment
There was a problem hiding this comment.
Looks pretty good. seems you got a pretty thourough understanding of ros now. wrt your question, things are organized better when nodes have a class that they instantiate and that class has members that are the action server, pubs, subs, etc. if your node is complex enough to warrant different classes, you can break them into different files and organize your code that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't make a .gitignore file since there are some files other than src and CMakeLists such as our custom msg, action, and launch file, that need to be included.
Also, I did all the tasks in one node like the instructions say but I found it difficult to keep my code organized this way. I was wondering whether this is more customary or having each task (e.g. each publisher, action, etc.) be a separate node. Is there a specific way that we should organize our nodes?
Thanks in advance for the review :)
🐢🐢🐢