Dynamic page size [non-breaking change]#375
Open
WeixuanZ wants to merge 2 commits intoutterance:masterfrom
Open
Dynamic page size [non-breaking change]#375WeixuanZ wants to merge 2 commits intoutterance:masterfrom
WeixuanZ wants to merge 2 commits intoutterance:masterfrom
Conversation
Added size optional argument, equaling 25 if not specified so old users will not see any difference. This addresses the issue of extra-long comment sections, causing scrolling difficulties. If the specified size is less than 16, the hidden-page size will increase exponentially until 16 is reached, avoiding problems with rate limiting. If the specified size is larger or equal to 16, the hidden-page size will be equal to the specified size. E.g. if no size argument is passed in, the hidden-page size will default to 25, which is the same as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #344. Added
sizeoptional argument, equaling 25 if not specified so existing users will not notice any difference. This addresses the issue of extra-long comment sections, causing scrolling difficulties.If the specified size is less than 16, the hidden-page size will increase exponentially until 16 is reached, avoiding problems with rate limiting.
If the specified size is larger or equal to 16, the hidden-page size will be equal to the specified size. E.g. if no
sizeargument is passed in, the hidden-page size will default to a constant of 25, which is the same as before.As the page size is now dynamic, logic to include penultimate page was also modified to be less than half of the given page size.
Setting
size=1: