fix: only use COMPRESS flag when compression is enabled#28
Merged
Conversation
The SWOOLE_WEBSOCKET_FLAG_COMPRESS flag was hardcoded in send(), which could cause issues with Swoole 6.1.6 when clients don't support permessage-deflate compression. Now the COMPRESS flag is only included when websocket_compression is explicitly enabled in the server config. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
WalkthroughThis pull request contains two changes: adding macOS metadata file (.DS_Store) to the .gitignore and refactoring the flag handling logic in the Swoole WebSocket adapter's send() method. The Swoole change extracts hardcoded WebSocket flags into a conditional variable that applies the compression flag only when websocket_compression is enabled in configuration. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
abnegate
added a commit
to appwrite/appwrite
that referenced
this pull request
Feb 5, 2026
Temporarily use dev branch (fix-conditional-compression) that only applies SWOOLE_WEBSOCKET_FLAG_COMPRESS when compression is enabled. This fixes websocket compatibility issues with Swoole 6.1.6. See: utopia-php/websocket#28 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SWOOLE_WEBSOCKET_FLAG_COMPRESSwhenwebsocket_compressionis enabled in configProblem
The
SWOOLE_WEBSOCKET_FLAG_COMPRESSflag was hardcoded in thesend()method, regardless of whether compression was actually enabled. With Swoole 6.1.6, this caused issues when sending messages to clients that don't support the permessage-deflate extension.Solution
Check the
websocket_compressionconfig value before including the compress flag in the push flags.🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
New Features