Conversation
There was a problem hiding this comment.
Pull request overview
This release (v11.1.7) focuses on improving the AWS CloudWatch integration by refactoring log collection to target a specific log group and enhancing the user setup documentation. The key changes streamline log processing, improve configuration logging, and provide comprehensive step-by-step guidance for AWS IAM and CloudWatch setup.
Key changes:
- Refactored AWS log collection to query a single target log group (
utmstack) instead of discovering all groups - Enhanced AWS IAM user setup guide with detailed instructions and updated screenshots
- Improved configuration logging to show module activation status and group count
Reviewed changes
Copilot reviewed 4 out of 30 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/aws/main.go | Refactored log collection to target a specific log group, moved log enqueueing into the processing loop, and removed the describeLogGroups function |
| plugins/aws/config/config.go | Enhanced configuration logging to display module activation status and group count instead of full config object |
| frontend/src/app/app-module/guides/guide-aws-iam-user/guide-aws-iam-user.component.html | Completely rewrote the AWS IAM setup guide with expanded steps, detailed CloudWatch/CloudTrail configuration, and new screenshots |
| CHANGELOG.md | Updated version to 11.1.7 and revised release notes to describe AWS integration improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frontend/src/app/app-module/guides/guide-aws-iam-user/guide-aws-iam-user.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/app-module/guides/guide-aws-iam-user/guide-aws-iam-user.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/app-module/guides/guide-aws-iam-user/guide-aws-iam-user.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: Manuel Abascal <mjabascal10@gmail.com>
Signed-off-by: Manuel Abascal <mjabascal10@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 30 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| logStreams, err := p.describeLogStreams(cwl, targetLogGroup) | ||
| if err != nil { | ||
| return nil, catcher.Error("cannot get log groups", err, nil) | ||
| return 0, catcher.Error("cannot get log streams for 'utmstack'", err, map[string]any{ |
There was a problem hiding this comment.
The error message contains a hardcoded log group name 'utmstack' instead of using the targetLogGroup constant. For consistency and maintainability, the error message should reference targetLogGroup or avoid duplicating the hardcoded string.
| return 0, catcher.Error("cannot get log streams for 'utmstack'", err, map[string]any{ | |
| return 0, catcher.Error(fmt.Sprintf("cannot get log streams for %q", targetLogGroup), err, map[string]any{ |
PLEASE READ BEFORE CONTINUING
To help us understand your contribution, please include the following in your pull request: