Skip to content

FIX #59 - always determine executable tests via annotation API before executing tests #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippSalvisberg merged 2 commits into from
Apr 28, 2019
Merged

FIX #59 - always determine executable tests via annotation API before executing tests #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f019a4e
fixes #59 - always use annotation API
PhilippSalvisberg Apr 28, 2019
6a89971
change to snapshot version 0.7.2-SNAPSHOT
PhilippSalvisberg Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqldev/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<!-- The Basics -->
<groupId>org.utplsql</groupId>
<artifactId>org.utplsql.sqldev</artifactId>
<version>0.7.1</version>
<version>0.7.2-SNAPSHOT</version>
<packaging>bundle</packaging>
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Expand Down
4 changes: 2 additions & 2 deletions sqldev/src/main/java/org/utplsql/sqldev/menu/UtplsqlController.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,8 @@ class UtplsqlController implements Controller {
connectionName = view.connectionName
}
logger.fine('''connectionName: «connectionName»''')
val preferences = PreferenceModel.getInstance(Preferences.preferences)
val parser = new UtplsqlParser(component.text, if (preferences.checkRunUtplsqlTest) {Connections.instance.getConnection(connectionName)} else {null}, owner)
// issue 59 - always use a connection to ensure the utPL/SQL annotation API is used
val parser = new UtplsqlParser(component.text, Connections.instance.getConnection(connectionName), owner)
val position = component.caretPosition
val path = parser.getPathAt(position)
val utPlsqlWorksheet = new UtplsqlWorksheet(path.pathList, connectionName)
Expand Down