Skip to content

Resolve security issues around insecure username for utplsql owner #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 2 commits into from
Sep 3, 2019
Merged

Resolve security issues around insecure username for utplsql owner #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc6a925
Resolve security issues around insecure username for utplsql owner
jgebal Sep 2, 2019
055ea8d
Adjusted download script to use some cookie logic
Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .travis/download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,19 @@ var agreementUrl = casper.cli.get(2);
var downloadUrl = casper.cli.get(3);
var downloaded = false;

phantom.addCookie({
'name': 'oraclelicense',
'value': '152021',
'domain': 'oracle.com'
});

casper.start();
// TODO: Error handling.

// Accept the license agreement.
casper.thenOpen(agreementUrl, function () {
// this.echo("Accepting License");
this.evaluate(function () {
acceptAgreement(window.self);
});
});

// Try to access the download page, wait for redirection and submit the login form.
casper.thenOpen(downloadUrl).waitForUrl(/signon\.jsp$/, function (re) {
// this.echo("Injecting Login Info");
//this.echo("Injecting Login Info");
this.evaluate(function (username, password) {
document.getElementById("sso_username").value = username;
document.getElementById("ssopassword").value = password;
Expand All @@ -42,8 +41,9 @@ casper.thenOpen(downloadUrl).waitForUrl(/signon\.jsp$/, function (re) {
});

casper.on("resource.received", function (resource) {
//this.echo("Received something: " + resource.url);
if (resource.url.indexOf("AuthParam") !== -1 && !downloaded) {
// this.echo("DownloadUrl:");
//this.echo("DownloadUrl:");
// Print the download url.
this.echo(resource.url);
downloaded = true;
Expand Down
1 change: 1 addition & 0 deletions .travis/download.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ fi
if [ "$PRODUCT" == "sqlcl" ]; then
agreementUrl="http://www.oracle.com/technetwork/developer-tools/sqlcl/downloads/index.html"
downloadUrl="https://download.oracle.com/otn/java/sqldeveloper/sqlcl-18.3.0.259.2029.zip"
#downloadUrl="https://download.oracle.com/otn/java/sqldeveloper/sqlcl-19.2.1.206.1649.zip"
outputFile=sqlcl-18.3.0.259.2029.zip
downloadFile $agreementUrl $downloadUrl $outputFile
exit 0
Expand Down
2 changes: 1 addition & 1 deletion source/core/ut_utils.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ create or replace package body ut_utils is

function ut_owner return varchar2 is
begin
return sys_context('userenv','current_schema');
return qualified_sql_name( sys_context('userenv','current_schema') );
end;

function scale_cardinality(a_cardinality natural) return natural is
Expand Down